Skip to content

fix: deCONZ: Handle unsupported status code for read parameter response #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koenkk merged 8 commits into from
Jul 2, 2025
Merged

fix: deCONZ: Handle unsupported status code for read parameter response #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
055f9e1
chore(master): release 4.3.1
Koenkk Jul 1, 2025
5941aed
fix: deCONZ: Handle unsupportes status code for read parameter response
manup Jul 1, 2025
89fd015
Update package.json
Koenkk Jul 2, 2025
15fcd17
Update CHANGELOG.md
Koenkk Jul 2, 2025
bde4735
Update .release-please-manifest.json
Koenkk Jul 2, 2025
367d529
Update package.json
Koenkk Jul 2, 2025
7ca25f1
Update package.json
Koenkk Jul 2, 2025
6018120
u
Koenkk Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/adapter/deconz/driver/driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,9 @@ class Driver extends events.EventEmitter {
this.paramTcAddress = tcAddress as bigint;
this.paramChannelMask = channelMask as number;
this.paramProtocolVersion = protocolVersion as number;
this.paramFrameCounter = frameCounter as number;
if (frameCounter !== null) {
this.paramFrameCounter = frameCounter as number;
}

// console.log({fwVersion, mac, panid, apsUseExtPanid, currentChannel, nwkKey, nwkUpdateId, channelMask, protocolVersion, frameCounter});

Expand Down
10 changes: 10 additions & 0 deletions src/adapter/deconz/driver/frameParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ function parseReadParameterResponse(view: DataView): Command | null {
let pos = 8;
let result = null;

if (status !== CommandStatus.Success) {
if (parameterId in ParamId) {
logger.debug(`Received read parameter response for ${ParamId[parameterId]}, seq: ${seqNumber}, status: ${status}`, NS);
}
return result;
}

switch (parameterId) {
case ParamId.MAC_ADDRESS: {
result = view.getBigUint64(pos, littleEndian);
Expand Down Expand Up @@ -610,6 +617,9 @@ function processFrame(frame: Uint8Array): void {

if (status === CommandStatus.Success) {
req.resolve(command);
} else if (status === CommandStatus.Unsupported && commandId === FirmwareCommand.ReadParameter) {
// resolve anyway to let higher layer handle unsupported
req.resolve(command);
} else {
let cmdName: string;
if (commandId in FirmwareCommand) {
Expand Down