`onZclData` throws `Cannot read properties of undefined (reading 'manufacturerName')`

[bobrippling]

On pairing a new device, I saw this as the device left the network prematurely:

warning:         z2m: Device '0x...' left the network
error:         zh:controller:endpoint: Tried to get unknown/deleted device 0x... from endpoint 1.

TypeError: Cannot read properties of undefined (reading 'manufacturerName')
    at Device.onZclData (.../zigbee-herdsman/src/controller/model/device.ts:431:64)
    at Controller.onZclPayload (.../zigbee-herdsman/src/controller/controller.ts:1017:13)

The only reference to manufacturerName in onZclData is on line 417:

zigbee-herdsman/src/controller/model/device.ts

Lines 413 to 420 in 4dd94ca

	const isDefaultResponse = frame.header.isGlobal && frame.command.name === "defaultRsp";
	const commandHasResponse = frame.command.response !== undefined;
	const disableDefaultResponse = frame.header.frameControl.disableDefaultResponse;
	/* v8 ignore next */
	const disableTuyaDefaultResponse = endpoint.getDevice().manufacturerName?.startsWith("_TZ") && process.env.DISABLE_TUYA_DEFAULT_RESPONSE;
	// Sometimes messages are received twice, prevent responding twice
	const alreadyResponded = this._lastDefaultResponseSequenceNumber === frame.header.transactionSequenceNumber;

I'm happy to put a PR together which investigates typing getDevice() to return undefined - it looks like I hit exactly the edge-case mentioned in #1330 (comment)

[Nerivec]

These edge-cases should only happen when something is wrong in the first place (some kind of race during cleanup).
Changing the typing on this particular function is far more complicated since the function is assumed to be called from a valid standpoint, pretty much everywhere (it would be a big 3-repo change).

About this particular case, I think the easiest is just to add an extra call at the top of Device.onZclData that validates the endpoint not being undefined, and returns if it is.
We probably also should do some extra checking in the caller, around these parts (not create endpoint/try to identify for deleted/delete-pending device):

zigbee-herdsman/src/controller/controller.ts

Lines 1019 to 1028 in 4dd94ca

	let endpoint = device.getEndpoint(payload.endpoint);
	if (!endpoint) {
	logger.debug(
	`Data is from unknown endpoint '${payload.endpoint}' from device with network address '${payload.address}', creating it...`,
	NS,
	);
	endpoint = device.createEndpoint(payload.endpoint);
	}

zigbee-herdsman/src/controller/controller.ts

Lines 993 to 1002 in 4dd94ca

	if (!device) {
	if (typeof payload.address === "number") {
	device = await this.identifyUnknownDevice(payload.address);
	}
	if (!device) {
	logger.debug(`Data is from unknown device with address '${payload.address}', skipping...`, NS);
	return;
	}
	}

[bobrippling]

Gotya, sounds like a plan. I'll see if I can put something together - thanks for your guidance