Skip to content

Add support for Inovelli's custom ledEffectComplete command #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koenkk merged 1 commit into from
Aug 4, 2025
Merged

Add support for Inovelli's custom ledEffectComplete command #9735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 55 additions & 7 deletions src/devices/inovelli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,10 @@ const inovelliExtend = {
{name: "duration", type: Zcl.DataType.UINT8},
],
},
ledEffectComplete: {
ID: 0x24,
parameters: [{name: "notificationType", type: Zcl.DataType.UINT8}],
},
},
commandsResponse: {},
}),
Expand Down Expand Up @@ -237,6 +241,17 @@ const inovelliExtend = {

const fanModes: {[key: string]: number} = {off: 0, low: 2, smart: 4, medium: 86, high: 170, on: 255};
const breezemodes: string[] = ["off", "low", "medium", "high"];
const LED_NOTIFICATION_TYPES: {[key: number]: string} = {
0: "LED_1",
1: "LED_2",
2: "LED_3",
3: "LED_4",
4: "LED_5",
5: "LED_6",
6: "LED_7",
16: "ALL_LEDS",
255: "CONFIG_BUTTON_DOUBLE_PRESS",
};

const INOVELLI = 0x122f;

Expand Down Expand Up @@ -2099,6 +2114,16 @@ const fzLocal = {
}
},
} satisfies Fz.Converter,
led_effect_complete: {
cluster: INOVELLI_CLUSTER_NAME,
type: ["commandLedEffectComplete"],
convert: (model, msg, publish, options, meta) => {
if (msg.data.notificationType in LED_NOTIFICATION_TYPES) {
return {notificationComplete: LED_NOTIFICATION_TYPES[msg.data.notificationType]};
}
return {notificationComplete: "Unknown"};
},
} satisfies Fz.Converter,
};

const exposeLedEffects = () => {
Expand Down Expand Up @@ -2177,17 +2202,31 @@ const exposeMMWaveControl = () => {
.withCategory("config");
};

const exposesListVZM30: Expose[] = [e.light_brightness(), exposeLedEffects(), exposeIndividualLedEffects()];
const exposeLedEffectComplete = () => {
return e
.enum("notificationComplete", ea.STATE_GET, Object.values(LED_NOTIFICATION_TYPES))
.withDescription("Indication that a specific notification has completed.")
.withCategory("diagnostic");
};

const exposesListVZM31: Expose[] = [e.light_brightness(), exposeLedEffects(), exposeIndividualLedEffects()];
const exposesListVZM30: Expose[] = [e.light_brightness(), exposeLedEffects(), exposeIndividualLedEffects(), exposeLedEffectComplete()];

const exposesListVZM32: Expose[] = [e.light_brightness(), exposeLedEffects(), exposeIndividualLedEffects(), exposeMMWaveControl()];
const exposesListVZM31: Expose[] = [e.light_brightness(), exposeLedEffects(), exposeIndividualLedEffects(), exposeLedEffectComplete()];

const exposesListVZM32: Expose[] = [
e.light_brightness(),
exposeLedEffects(),
exposeIndividualLedEffects(),
exposeMMWaveControl(),
exposeLedEffectComplete(),
];

const exposesListVZM35: Expose[] = [
e.fan().withState("fan_state").withModes(Object.keys(fanModes)),
exposeLedEffects(),
exposeIndividualLedEffects(),
exposeBreezeMode(),
exposeLedEffectComplete(),
];

const exposesListVZM36: Expose[] = [e.light_brightness(), e.fan().withState("fan_state").withModes(Object.keys(fanModes)), exposeBreezeMode()];
Expand Down Expand Up @@ -2277,6 +2316,7 @@ export const definitions: DefinitionWithExtend[] = [
fz.power_on_behavior,
fz.ignore_basic_report,
fzLocal.inovelli(VZM30_ATTRIBUTES, INOVELLI_CLUSTER_NAME),
fzLocal.led_effect_complete,
],
ota: true,
configure: async (device, coordinatorEndpoint) => {
Expand Down Expand Up @@ -2329,11 +2369,12 @@ export const definitions: DefinitionWithExtend[] = [
fz.power_on_behavior,
fz.ignore_basic_report,
fzLocal.inovelli(VZM31_ATTRIBUTES, INOVELLI_CLUSTER_NAME),
fzLocal.led_effect_complete,
],
ota: true,
configure: async (device, coordinatorEndpoint) => {
const endpoint = device.getEndpoint(1);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl"]);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl", INOVELLI_CLUSTER_NAME]);
await reporting.onOff(endpoint);

await chunkedRead(endpoint, Object.keys(VZM31_ATTRIBUTES), INOVELLI_CLUSTER_NAME);
Expand Down Expand Up @@ -2383,11 +2424,12 @@ export const definitions: DefinitionWithExtend[] = [
fz.ignore_basic_report,
fzLocal.inovelli(VZM32_ATTRIBUTES, INOVELLI_CLUSTER_NAME),
fzLocal.inovelli(VZM32_MMWAVE_ATTRIBUTES, INOVELLI_MMWAVE_CLUSTER_NAME),
fzLocal.led_effect_complete,
],
ota: true,
configure: async (device, coordinatorEndpoint) => {
const endpoint = device.getEndpoint(1);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl"]);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl", INOVELLI_CLUSTER_NAME]);
await reporting.onOff(endpoint);

await chunkedRead(endpoint, Object.keys(VZM32_ATTRIBUTES), INOVELLI_CLUSTER_NAME);
Expand All @@ -2403,7 +2445,13 @@ export const definitions: DefinitionWithExtend[] = [
model: "VZM35-SN",
vendor: "Inovelli",
description: "Fan controller",
fromZigbee: [fzLocal.fan_state, fzLocal.fan_mode(1), fzLocal.breeze_mode(1), fzLocal.inovelli(VZM35_ATTRIBUTES, INOVELLI_CLUSTER_NAME)],
fromZigbee: [
fzLocal.fan_state,
fzLocal.fan_mode(1),
fzLocal.breeze_mode(1),
fzLocal.inovelli(VZM35_ATTRIBUTES, INOVELLI_CLUSTER_NAME),
fzLocal.led_effect_complete,
],
toZigbee: [
tz.identify,
tzLocal.fan_state,
Expand All @@ -2419,7 +2467,7 @@ export const definitions: DefinitionWithExtend[] = [
ota: true,
configure: async (device, coordinatorEndpoint) => {
const endpoint = device.getEndpoint(1);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl"]);
await reporting.bind(endpoint, coordinatorEndpoint, ["genOnOff", "genLevelCtrl", INOVELLI_CLUSTER_NAME]);

await chunkedRead(endpoint, Object.keys(VZM35_ATTRIBUTES), INOVELLI_CLUSTER_NAME);

Expand Down
Loading