Tidying up messy PRs of Excellux devices #11451
Open
+32
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed NTCHT-01 to ZG-105NTH and minor improved. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Changed model from 'FEDHT-01' to 'DHT0001', added whiteLabel for 'DHTA001', and minor improved. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Changed model from 'PIRIV-01' to 'ZG-104PLV' and minor improved. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Changed from 'Contact-01' to 'ZG-102MV' and minor improved. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Changed model from 'VABRATE-01' to 'ZG-103V'. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Corrected the model name from 'Scene-Switc' to 'ZG-101K'. NB: I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Replaced custom battery percentage exposes with e.battery() for consistency and simplified code. Removed redundant 'withUnit("times")' from vibration sensitivity exposes.
Bjk8kds
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidying up messy PRs.
I only tidied up the appearance/cosmetics related stuff, like naming, etc, without changing the converter logic inside.
Original commit: ------------------------------------------- This commit:
Other:
S→s(seconds)illumiance→illuminancepresence_state→presencee.battery().withUnit("times")fromvibration_sensitivityRelated:
ZHC
Add varbate sensor of Excellux #11297
Add Excellux sensor #11290
z2m.io
Add some Excellux sensors zigbee2mqtt.io#4723
Add some Excellux sensors zigbee2mqtt.io#4726
Update sensor images zigbee2mqtt.io#4771
Link to picture pull request:
NB: For PNG images, it will follow because it has been committed by the original contributor, just need to clean up unused images after the next update.