-
Notifications
You must be signed in to change notification settings - Fork 4k
fix!: Make configureKey explicit #11148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The old name Might also have to add some specific versioning in this Z2M release for changed converters (have to check all since 1), so they don't ignore reconfigure because of default |
|
I think a re-interview can also be done from the configure itself (or just the specific action needed, e.g. node descriptor request) but I get the point. I'm not sure if |
|
Too much maintenance in my opinion, and grows definition payloads, database size, exponentially with each "trigger" that's needed (future problems).
I guess first we should identify the list of currently needed triggers though, see how it would currently work. You know converters better than me but I figured something along the lines of:
|
|
I see, shall when than start with just a single digit version? Because only the re-configure is needed now. |
|
Your call, guess it depends if you see a need for re-interview and more in the near future. Would need to refactor for compat if you want to implement other needs (semver would not be |
Before the
configureKeywas automatically calculated based on the hash of the function. This has 2 big drawbacks:configuredoesn't change (and therefore the hash doesn't), so no re-configure is done when actually needed.This PR makes the configureKey explicit again (like it was a long time ago) so we can decide on the definition level wether a device should be re-configured.