Skip to content

Adjust MOSZB-140 reporting configuration to fix excessive reports #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koenkk merged 2 commits into from
Sep 27, 2025
Merged

Adjust MOSZB-140 reporting configuration to fix excessive reports #10081

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9326ca8
Adjust MOSZB-140 reporting configuration to fix excessive reports
gluoncompany Sep 25, 2025
e7593cd
Update develco.ts
Koenkk Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/devices/develco.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,8 @@ export const definitions: DefinitionWithExtend[] = [
extend: [
develcoModernExtend.addCustomClusterManuSpecificDevelcoGenBasic(),
develcoModernExtend.readGenBasicPrimaryVersions(),
develcoModernExtend.temperature(), // TODO: ep 38
m.illuminance(), // TODO: ep 39
develcoModernExtend.temperature({reporting: {min: 10, max: 3600, change: 100}}),
m.illuminance({reporting: {min: 10, max: 3600, change: 100}}),
Copy link
Owner

@Koenkk Koenkk Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often are both values reported? The default reporting values should be good (at least that is the goal of it)

Copy link
Contributor Author

@gluoncompany gluoncompany Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default temperature report is the same as in the code, but the brightness report value is set to 5 ("change: 5"). This causes it to report constantly and not enter deep sleep, draining the battery. I forced the temperature setting in case the manufacturer changed any parameters so it wouldn't be affected. This could be removed from my change if you want.

m.battery({
voltageToPercentage: {min: 2500, max: 3000},
percentage: true,
Expand Down