Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions tests/test_workers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import logging

import pytest


@pytest.mark.filterwarnings("ignore:The `uvicorn.workers` module is deprecated:DeprecationWarning")
def test_gunicorn_access_formatter_honors_access_log_format() -> None:
from uvicorn.workers import GunicornAccessFormatter

formatter = GunicornAccessFormatter('%(h)s %(m)s %(U)s %(q)s %(s)s "%(a)s"')
record = logging.LogRecord(
name="uvicorn.access",
level=logging.INFO,
pathname=__file__,
lineno=1,
msg='%s - "%s %s HTTP/%s" %d',
args=("127.0.0.1:12345", "GET", "/hello?name=uvicorn", "1.1", 204),
exc_info=None,
)

assert formatter.format(record) == '127.0.0.1 GET /hello name=uvicorn 204 "-"'


@pytest.mark.filterwarnings("ignore:The `uvicorn.workers` module is deprecated:DeprecationWarning")
def test_gunicorn_access_formatter_leaves_non_uvicorn_records_unchanged() -> None:
from uvicorn.workers import GunicornAccessFormatter

formatter = GunicornAccessFormatter("%(h)s %(r)s %(s)s")
record = logging.LogRecord(
name="uvicorn.access",
level=logging.INFO,
pathname=__file__,
lineno=1,
msg="already formatted",
args=(),
exc_info=None,
)

assert formatter.format(record) == "already formatted"
62 changes: 62 additions & 0 deletions uvicorn/workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@

import asyncio
import logging
import os
import signal
import sys
import warnings
from copy import copy
from typing import Any
from urllib.parse import urlsplit

from gunicorn.arbiter import Arbiter
from gunicorn.glogging import SafeAtoms
from gunicorn.workers.base import Worker

from uvicorn._compat import asyncio_run
Expand All @@ -21,6 +25,62 @@
)


class GunicornAccessFormatter(logging.Formatter):
"""Format Uvicorn access records using Gunicorn's access log format."""

def __init__(self, access_log_format: str) -> None:
super().__init__("%(message)s")
self.access_log_format = access_log_format

def format(self, record: logging.LogRecord) -> str:
if _is_uvicorn_access_record(record):
record = copy(record)
record.msg = self.access_log_format
record.args = _format_record_args(record.args) # type: ignore[arg-type]
return super().format(record)


def _is_uvicorn_access_record(record: logging.LogRecord) -> bool:
return bool(
record.name == "uvicorn.access"
and record.msg == '%s - "%s %s HTTP/%s" %d'
and isinstance(record.args, tuple)
and len(record.args) == 5
)


def _format_record_args(args: tuple[Any, ...]) -> dict[str, Any]:
client_addr, method, full_path, http_version, status_code = args
client_host = str(client_addr).rsplit(":", 1)[0]
parsed_path = urlsplit(str(full_path))
path = parsed_path.path or "-"
query = parsed_path.query
request_line = f"{method} {full_path} HTTP/{http_version}"

atoms = {
"h": client_host,
"l": "-",
"u": "-",
"t": "-",
"r": request_line,
"s": status_code,
"m": method,
"U": path,
"q": query,
"H": f"HTTP/{http_version}",
"b": "-",
"B": None,
"f": "-",
"a": "-",
"T": 0,
"D": 0,
"M": 0,
"L": "0.000000",
"p": f"<{os.getpid()}>",
}
return SafeAtoms(atoms)


class UvicornWorker(Worker):
"""
A worker class for Gunicorn that interfaces with an ASGI consumer callable,
Expand All @@ -40,6 +100,8 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
logger = logging.getLogger("uvicorn.access")
logger.handlers = self.log.access_log.handlers
logger.setLevel(self.log.access_log.level)
for handler in logger.handlers:
handler.setFormatter(GunicornAccessFormatter(self.cfg.access_log_format))
logger.propagate = False

config_kwargs: dict = {
Expand Down