Treat fd=0 as a valid file descriptor with reload/workers#2927
Merged
Kludex merged 3 commits intoKludex:mainfrom Apr 30, 2026
Merged
Treat fd=0 as a valid file descriptor with reload/workers#2927Kludex merged 3 commits intoKludex:mainfrom
fd=0 as a valid file descriptor with reload/workers#2927Kludex merged 3 commits intoKludex:mainfrom
Conversation
07f4536 to
16fd694
Compare
Also, check uds for None for consistency with Server.startup().
5592283 to
7ddfab6
Compare
--fd=0 with reload/workersfd=0 as a valid file descriptor with reload/workers
Kludex
approved these changes
Apr 30, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing a socket as stdin (
--fd=0) currently does not work in modes that use subprocesses (i.e. with--reloadand--workers), becauseconfig.fdis checked for truthiness instead of forNone.Checklist