Add note about --timeout-keep-alive being measured in seconds#2669
Merged
Kludex merged 4 commits intoKludex:mainfrom Sep 23, 2025
Merged
Add note about --timeout-keep-alive being measured in seconds#2669Kludex merged 4 commits intoKludex:mainfrom
--timeout-keep-alive being measured in seconds#2669Kludex merged 4 commits intoKludex:mainfrom
Conversation
Kludex
approved these changes
Sep 13, 2025
Kludex
approved these changes
Sep 23, 2025
--timeout-keep-alive being measured in seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update command-line/docs to mention --timeout-keep-alive is measured in seconds.
I believe this is correct since this value is ultimately passed to loop.call_later
Here:
https://github.com/encode/uvicorn/blob/c1144fd4f130388cffc05ee17b08747ce8c1be11/uvicorn/protocols/http/h11_impl.py#L318
and here:
https://github.com/encode/uvicorn/blob/c1144fd4f130388cffc05ee17b08747ce8c1be11/uvicorn/protocols/http/httptools_impl.py#L332-L334
Checklist