Skip to content

Add note about --timeout-keep-alive being measured in seconds#2669

Merged
Kludex merged 4 commits intoKludex:mainfrom
LincolnPuzey:patch-1
Sep 23, 2025
Merged

Add note about --timeout-keep-alive being measured in seconds#2669
Kludex merged 4 commits intoKludex:mainfrom
LincolnPuzey:patch-1

Conversation

@LincolnPuzey
Copy link
Copy Markdown
Contributor

Summary

Update command-line/docs to mention --timeout-keep-alive is measured in seconds.
I believe this is correct since this value is ultimately passed to loop.call_later

Here:
https://github.com/encode/uvicorn/blob/c1144fd4f130388cffc05ee17b08747ce8c1be11/uvicorn/protocols/http/h11_impl.py#L318

and here:
https://github.com/encode/uvicorn/blob/c1144fd4f130388cffc05ee17b08747ce8c1be11/uvicorn/protocols/http/httptools_impl.py#L332-L334

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex changed the title Update command-line/docs to mention --timeout-keep-alive is measured in seconds Add note about --timeout-keep-alive being measured in seconds Sep 23, 2025
@Kludex Kludex enabled auto-merge (squash) September 23, 2025 13:02
@Kludex Kludex merged commit bbe119e into Kludex:main Sep 23, 2025
44 of 48 checks passed
@LincolnPuzey LincolnPuzey deleted the patch-1 branch September 23, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants