-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
modified: Deployment_Log.txt #7104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
new file: Deployment_Log.txt new file: README.txt new file: Test_Results.txt new file: config/manta_m4p_v2_enderv3.cfg modified: Deployment_Log.txt modified: README.txt scripts/flash_stm32_usb_dfu.ps1
modified: README.txt new file: scripts/flash_stm32_usb_dfu.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds complete documentation and configuration for deploying Klipper firmware to a BTT Manta M4P v2.0 board with an Ender 3 V3 printer setup. The changes introduce flashing scripts, configuration files, deployment tracking, and a comprehensive guide for reproducible firmware builds and deployment.
Key Changes:
- PowerShell script for automated Windows-based firmware flashing via USB DFU
- Printer configuration file for Manta M4P v2.0 with Ender 3 V3 hardware
- Documentation files for deployment tracking, testing protocols, and comprehensive setup guide
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 22 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/flash_stm32_usb_dfu.ps1 | PowerShell automation script for flashing firmware via STM32CubeProgrammer CLI |
| config/manta_m4p_v2_enderv3.cfg | Klipper printer configuration using alias-based pin naming for Manta M4P v2.0 |
| Test_Results.txt | Test plan template for hardware validation |
| README.txt | Comprehensive deployment guide with build instructions and troubleshooting |
| Deployment_Log.txt | Firmware deployment tracking with version and checksum information |
| CHANGELOG.txt | Change history documenting the additions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| step_pin: MOTOR0_STEP | ||
| dir_pin: MOTOR0_DIR | ||
| enable_pin: !MOTOR0_EN |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration uses alias names (e.g., MOTOR0_STEP, MOTOR0_DIR, MOTOR0_EN) that are never defined. These aliases need to be defined in a [board_pins] section mapping them to actual STM32G0B1 pins, or the actual pin names should be used directly. Based on the existing generic-bigtreetech-manta-m4p.cfg, MOTOR0_STEP should be PC6, MOTOR0_DIR should be PA14, and MOTOR0_EN should be PC7.
| position_max: 235 | ||
|
|
||
| [tmc2209 stepper_x] | ||
| uart_pin: MOTOR0_UART |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alias MOTOR0_UART is undefined. Based on the existing generic-bigtreetech-manta-m4p.cfg, the UART pin for the X motor (motor 0) should be PB12.
| uart_pin: MOTOR0_UART | |
| uart_pin: PB12 |
| step_pin: MOTOR1_STEP | ||
| dir_pin: MOTOR1_DIR | ||
| enable_pin: !MOTOR1_EN |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aliases MOTOR1_STEP, MOTOR1_DIR, and MOTOR1_EN are undefined. Based on the existing board configuration, these should be PB10, PB2, and PB11 respectively.
| position_max: 235 | ||
|
|
||
| [tmc2209 stepper_y] | ||
| uart_pin: MOTOR1_UART |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alias MOTOR1_UART is undefined. Based on the existing board configuration, this should be PC10.
| uart_pin: MOTOR1_UART | |
| uart_pin: PC10 |
| step_pin: MOTOR2_STEP | ||
| dir_pin: MOTOR2_DIR | ||
| enable_pin: !MOTOR2_EN |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aliases MOTOR2_STEP, MOTOR2_DIR, and MOTOR2_EN are undefined. Based on the existing board configuration, these should be PB0, PC5, and PB1 respectively.
| heater_temp: 50.0 | ||
|
|
||
| [bltouch] | ||
| sensor_pin: PROBE_SIGNAL |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alias PROBE_SIGNAL is undefined. Based on the existing board configuration, this should be PC14.
| sensor_pin: PROBE_SIGNAL | |
| sensor_pin: PC14 |
|
|
||
| [bltouch] | ||
| sensor_pin: PROBE_SIGNAL | ||
| control_pin: PROBE_SERVO |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alias PROBE_SERVO is undefined. Based on the existing board configuration, this should be PA1.
| microsteps: 16 | ||
| endstop_pin: ^X_STOP | ||
| position_endstop: 0 | ||
| position_min: 0 |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position_min: 0 setting may prevent homing adjustments. Consider setting this to a small negative value (e.g., -5) to allow for Z-offset calibration with the BLTouch probe, which is configured with offsets at lines 105-107.
|
|
||
| Prereqs: | ||
| - Install STM32CubeProgrammer (includes STM32_Programmer_CLI.exe) | ||
| - Board in DFU mode (BOOT0+RST per WINDOWS_FLASHING.md) |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference to WINDOWS_FLASHING.md that doesn't exist in the repository. This should either reference an existing documentation file (e.g., README.txt which contains the DFU instructions on line 42-47) or the non-existent file should be created.
| - Board in DFU mode (BOOT0+RST per WINDOWS_FLASHING.md) | |
| - Board in DFU mode (BOOT0+RST per README.txt lines 42-47) |
| - Driver issues: install STM32CubeProgrammer or use Zadig WinUSB for DFU. | ||
| - Wrong offset: confirm `.config` bootloader and start address alignment. | ||
| - Serial mismatch: always use `/dev/serial/by-id/...` not `/dev/tty*`. | ||
| - Verification: `out/klipper.bin.sha256` contains the SHA256 of the built firmware (generated via `certutil`). Use it to validate the binary before flashing and for post-flash integrity checks. |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 68 has inconsistent indentation - it starts with | followed by a space and dash, while other lines use just a dash. This should be - Verification: to match the formatting of lines 64-67.
| - Verification: `out/klipper.bin.sha256` contains the SHA256 of the built firmware (generated via `certutil`). Use it to validate the binary before flashing and for post-flash integrity checks. | |
| - Verification: `out/klipper.bin.sha256` contains the SHA256 of the built firmware (generated via `certutil`). Use it to validate the binary before flashing and for post-flash integrity checks. |
|
I am not sure what this the intent of this is? the klipper repo does not include printer and non-stock equipment configs, let alone AI generated code and deployment guides. This would be better suited on a creality specific forum where it can be targeted to the proper intended use base. As this stands it wont be considered for inclusion. Thanks |
modified: README.txt
new file: scripts/flash_stm32_usb_dfu.ps1