Extend PropertyInitialValueSetEventArgs and PropertyReassignmentEventArgs

[YuliiaKovalova]

Context

related to dotnet/msbuild#11106
fixes: #268

Extend PropertyInitialValueSetEventArgs to include precise location details (file, line, column) and modify the formatting approach for PropertyReassignmentEventArgs.

[JanKrivanek]

Thank you!

[KirillOsenkov]

@YuliiaKovalova just to confirm, I think we should test the following scenarios.

I suggest let's record two binlogs from your PR (dotnet/msbuild#11106), one with no special settings (1.binlog), and one with property tracking enabled (2.binlog). Let's also have a regular old binlog of version 24 (3.binlog).

• this build of the viewer opens 1.binlog
• this build of the viewer opens 2.binlog
• this build of the viewer opens 3.binlog
• old viewer opens 1.binlog
• old viewer opens 2.binlog

If it all works fine, let me know and I'll merge and publish a new viewer version. After that we can merge dotnet/msbuild#11106

Thanks a lot!

[YuliiaKovalova]

@YuliiaKovalova just to confirm, I think we should test the following scenarios.

I suggest let's record two binlogs from your PR (dotnet/msbuild#11106), one with no special settings (1.binlog), and one with property tracking enabled (2.binlog). Let's also have a regular old binlog of version 24 (3.binlog).

• [*] this build of the viewer opens 1.binlog
• [*] this build of the viewer opens 2.binlog
• [*] this build of the viewer opens 3.binlog
• [*] old viewer opens 1.binlog
• old viewer opens 2.binlog NOPE

If it all works fine, let me know and I'll merge and publish a new viewer version. After that we can merge dotnet/msbuild#11106

Thanks a lot!

The old viewer opens 2.binlog, but doesn't contain info about PropertyAssignment and UninitializedPropertyRead because I moved raw messages to LogViewer

MSBuildStructuredLog/src/StructuredLogger/Strings/Strings.json

Line 38 in 9bc29f2

"PropertyAssignment": "Property initial value: $({0})=\"{1}\". Source: {2}",

and stopped passing a message from msbuild side for these two
https://github.com/dotnet/msbuild/blob/bdadaea8aa91de921767a5686592dfd86d62c299/src/Build/Logging/BinaryLogger/BuildEventArgsWriter.cs#L589

Should I handle it somehow differently or it's ok to have this breaking change for the sake of perf savings?

[KirillOsenkov]

No, that's fine I think. Thanks a lot!

[KirillOsenkov]

I published https://github.com/KirillOsenkov/MSBuildStructuredLog/releases/tag/v2.2.441