Skip to content

Comments

WinUI like Resource Management and Localization#225

Merged
Kinnara merged 4 commits intoKinnara:masterfrom
ShankarBUS:ResourceManagement
Mar 9, 2021
Merged

WinUI like Resource Management and Localization#225
Kinnara merged 4 commits intoKinnara:masterfrom
ShankarBUS:ResourceManagement

Conversation

@ShankarBUS
Copy link
Contributor

Fixes #202.

@ShankarBUS
Copy link
Contributor Author

I won't recommend merging this PR without a discussion and proper planning.

Even though this PR would benefit porting of new controls, this may break this library.

Think and decide. I'll wait.

And oh my! The changes are quite large 😅 (~50k lines?). Please look carefully at just the code changes and not the *.resx files.

@ShankarBUS
Copy link
Contributor Author

Please take a look at this carefully #202 (comment)

@ShankarBUS
Copy link
Contributor Author

The PR is ready to be merged.

Well looks like the CI failed while installing deps. The build process didn't even start. So, I guess it not a problem.

@ShankarBUS ShankarBUS requested a review from Kinnara January 8, 2021 17:44
@Kinnara
Copy link
Owner

Kinnara commented Feb 26, 2021

Great work. I noticed the ResourceAccessor class was getting larger and experimented with some changes to simplify it in cf339ee. I'd love to hear your thoughts on them.

@ShankarBUS
Copy link
Contributor Author

Looks great! You simplified it really well!

@Kinnara
Copy link
Owner

Kinnara commented Mar 3, 2021

Glad to hear! Would you like to update the PR to incorporate those changes before merging? Or I can do it after merging.

@ShankarBUS
Copy link
Contributor Author

I stopped programming. So, you have to do the changes yourself after merging this PR.

@Kinnara
Copy link
Owner

Kinnara commented Mar 9, 2021

I see. Thank you very much for your contributions and help!

@Kinnara Kinnara merged commit ee4def8 into Kinnara:master Mar 9, 2021
@Kinnara Kinnara added this to the 0.9.4 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codebase Suggestion: Make Resource management and Multilingual support mechanisms consistent with WinUI

2 participants