fix: restore newlines in command display and filter multi-line patterns #3931
+97
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore newlines/carriage returns in CommandExecution display that were protected during parsing - Filter out multi-line commands from pattern selector to show only clean patterns (e.g., 'echo' instead of full multi-line text) - Add tests to verify placeholders are not visible in UI and multi-line commands are filtered from patterns - Fixes issue where ___NEWLINE___ and ___CARRIAGE_RETURN___ placeholders were visible in UI
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the UI display issue where newline placeholders were visible in the command execution display and multi-line commands were cluttering the pattern selector.
Changes
Testing
✅ All 17 quote protection tests pass
✅ All 136 command validation tests pass
✅ All 3 new UI display tests pass
✅ All 388 chat and validation tests pass
Before
___NEWLINE___and___CARRIAGE_RETURN___were visible in the UIAfter