feat: Add request deduplication to GhostInlineCompletionProvider #3889
+1,796
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markijbema
force-pushed
the
feature/ghost-request-deduplication
branch
from
a4d75c3 to
57a28f0
Compare
Implements Approach 3 (Hybrid - Request Deduplication with Intelligent Cancellation) to optimize autocomplete performance: - Add PendingSuggestion interface and pendingRequests Map to track in-flight API requests - Implement getCacheKey() for unique request identification - Implement findReusablePendingRequest() to intelligently reuse pending requests - Enhanced fetchAndCacheSuggestion() with: * Deduplication of identical requests (same prefix/suffix) * Reuse of pending requests when user types ahead * Automatic adjustment of suggestions to remove already-typed text * Cancellation of obsolete requests when prefix diverges * Proper cleanup of completed requests - Update dispose() to cancel all pending requests on cleanup - Add comprehensive test suite for request deduplication functionality Benefits: - Prevents duplicate API calls for identical contexts - Reduces latency when user types ahead of completion - Maintains existing chunk-based architecture - Low risk, incremental improvement - Can evolve to full streaming approach later if needed
Fixed timeout issues in request deduplication tests by ensuring all pending debounce promises are properly resolved. The previous implementation would create new promises on each call but never resolve old ones when the timer was cleared and reset. Changes: - Added pendingDebounceResolvers array to track all promise resolvers - Resolve all accumulated promises when debounce timer fires - Distinguish between 'typing ahead' (reuse request) and 'diverging' (flush and start new) - Clear pending resolvers in dispose() method - Updated test helpers to properly handle async timer advancement All 5458 tests now pass, including the 5 request deduplication tests that were previously timing out after 20 seconds.
markijbema
force-pushed
the
feature/ghost-request-deduplication
branch
from
57a28f0 to
68c9e6d
Compare
…sses - Create RequestDebouncer class to handle debouncing logic separately - Create RequestDeduplicator class to manage request deduplication - Refactor GhostInlineCompletionProvider to use helper classes - Add comprehensive test coverage for both helper classes (26 tests) - Reduce state management complexity from 3 variables to 2 helper instances - Extract helper methods: adjustSuggestion(), isAbortError(), executeRequest() - Add PR review document analyzing complexity vs original implementation - Add complexity reduction plan with detailed refactoring strategy Benefits: - Better separation of concerns - Improved testability and maintainability - Reduced cognitive complexity in main provider class - Each component can be tested and modified independently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Approach 3 (Hybrid - Request Deduplication with Intelligent Cancellation) to optimize autocomplete performance:
Benefits:
Context
Implementation
Screenshots
How to Test
Get in Touch