This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Added DE119-XX-XX from DE152-XX-XX (copy)#2424
Open
valerionew wants to merge 1 commit intoKiCad:masterfrom
Open
Added DE119-XX-XX from DE152-XX-XX (copy)#2424valerionew wants to merge 1 commit intoKiCad:masterfrom
valerionew wants to merge 1 commit intoKiCad:masterfrom
Conversation
6 tasks
Collaborator
|
Thanks @valerionew One comment (also applies to DE152):
Else looks good. |
bc1486b to
efabd0d
Compare
Contributor
Author
efabd0d to
5a177ba
Compare
Collaborator
|
Hello @valerionew I still not agree, I have 3.058mm actually.... Something wrong with the force push ? |
5a177ba to
ba10752
Compare
Contributor
Author
|
It must have been a silly mistake on my side, please check if everything is in order now |
Collaborator
|
It's better.
Else looks good |
Collaborator
|
@valerionew ping |
Collaborator
|
No news of the author, indicate this is Abandoned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Same as #2423 but for DE119. Symbol PR: KiCad/kicad-symbols#2936
The footprint is the same, the symbol changes by 1 pin
DS: https://www.display-elektronik.de/filter/DE119-RS-20_635.pdf

All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)