Use CMAKE_INSTALL_FULL_LIBDIR in compat cmake files#3067
Merged
arcady-lunarg merged 1 commit intoKhronosGroup:mainfrom May 2, 2023
Merged
Use CMAKE_INSTALL_FULL_LIBDIR in compat cmake files#3067arcady-lunarg merged 1 commit intoKhronosGroup:mainfrom
arcady-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
|
|
13 tasks
According to https://cmake.org/cmake/help/v3.25/module/GNUInstallDirs.html, CMAKE_INSTALL_LIBDIR can be an absolute path. For instance, Nixpkgs [defined it to an absolute path in /nix/store](https://github.com/NixOS/nixpkgs/blob/3d17b4c305cefef284109fa9d426b00f3e5072c6/pkgs/development/tools/build-managers/cmake/setup-hook.sh#L101). The output in this case is: # result-glslang/lib/cmake/glslangTargets.cmake:5 include("${CMAKE_CURRENT_LIST_DIR}/../..//nix/store/3mif2zibig0cilk5dbz334278n0vlq9s-glslang-1.3.231.0/lib/glslang/glslang-targets.cmake") Signed-off-by: Chuang Zhu <git@chuang.cz>
arcady-lunarg
force-pushed
the
cmake-install-full-libdir
branch
from
7627bd8 to
8fbdbf7
Compare
arcady-lunarg
approved these changes
May 2, 2023
Contributor
arcady-lunarg
left a comment
arcady-lunarg
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to
https://cmake.org/cmake/help/v3.25/module/GNUInstallDirs.html, CMAKE_INSTALL_LIBDIR can be an absolute path. For instance, Nixpkgs defined it to an absolute path in /nix/store. The output in this case is:
Signed-off-by: Chuang Zhu git@chuang.cz