Add tests for gl.readPixels(), gl.texImage2D() and gl.texSubImage2D() from Wasm Memories of 4GB and 16GB in size. #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from Wasm Memories of 4GB and 16GB in size.
|
|
kenrussell
approved these changes
Sep 22, 2023
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Thank you Jukka for these tests!
With a small modification to make them runnable directly without URL query parameters, the 4 GB tests pass in Chromium ToT and Safari Tech Preview. They happen to fail in Firefox for reasons discussed in this week's WebGL concall; this will be worked on by the Mozilla team.
The 16 GB tests fail on all browsers right now. This seems fine; better to have the tests in place and decide whether to run them as part of the next conformance test snapshot later.
Deleted trailing whitespace.
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Sep 22, 2023
This makes them runnable by navigating to them outside of the test harness and without URL query parameters. Follow-on to KhronosGroup#3592.
kenrussell
added a commit
that referenced
this pull request
Sep 22, 2023
) This makes them runnable by navigating to them outside of the test harness and without URL query parameters. Follow-on to #3592.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for gl.readPixels(), gl.texImage2D() and gl.texSubImage2D() from Wasm Memories of 4GB and 16GB in size.
CC @kenrussell