Skip to content

Conversation

@asuessenbach
Copy link
Contributor

Resolves #1943.

@sharadhr
Copy link
Contributor

This looks reasonable to me. @stripe2933 I don't have another compiler at hand to test—would you be able to chime in as well?

@stripe2933
Copy link
Contributor

Tested on Clang 18 and MSVC 14.42. Here's the CI link.

  • Clang is not affected by this patch (std::hash<(vulkan-type)>s are implicitly exported by its module implementation nature.
  • MSVC affected by this patch. Patch before Patch after

Thank for your efforts.

@asuessenbach
Copy link
Contributor Author

@stripe2933, @sharadhr: Thanks a lot for your help with this issue!

@asuessenbach asuessenbach merged commit cdfa83a into KhronosGroup:main Nov 26, 2024
21 checks passed
@asuessenbach asuessenbach deleted the hash branch November 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<vulkan/vulkan_hash.hpp> included in vulkan.cppm but std::hash specializations are not exported.

3 participants