-
Notifications
You must be signed in to change notification settings - Fork 251
Implement extension SPV_KHR_float_controls2 #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmmartinez
wants to merge
23
commits into
KhronosGroup:main
Choose a base branch
from
jmmartinez:users/jmmartinez/spv_khr_float_controls2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7ca5c71
Implement extension SPV_KHR_float_controls2
jmmartinez bd74ca9
[Review] set FPFastMathDefault equal to 0 for every entry-point
jmmartinez d0d26f2
[Review] Add test showing reassoc->AllowTransform->reassoc contract
jmmartinez 2b25d20
[Review] add fcmp and ExtInst tests
jmmartinez 08aee52
Ignore FPFastMathMode decorations attached as metadata
jmmartinez 03e9a61
Add test with multiple floating point types
jmmartinez e8eb865
[Review] reword FPFastMathMode decoration metadata comment
jmmartinez 97211a8
[Review] fix typo in execution_mode_default.ll
jmmartinez d58da85
[Review] rename CHECK->SPIRV in execution_mode_default.ll
jmmartinez 7321ab2
[Review] add reverse translation tests for execution_mode_default.ll
jmmartinez 0f02365
[Review] remove word-count from SPIRV checks in execution_mode_defaul…
jmmartinez fe86d9c
[Review] remove word-count from SPIRV checks in fp-decorate-twice.ll
jmmartinez 48424af
[Review] Pre-commit tests before changing the logic of transFPFastMat…
jmmartinez 49600ab
[Review] Update transFPFastMathDefault
jmmartinez e7f4886
[Review][NFC] Comments and renames
jmmartinez 1802fde
[Review][NFC] Add assertions
jmmartinez 4967f1c
[Review] Propagate FP mode to vector types
jmmartinez 97c9d7a
[Review] missing space
jmmartinez 5e6e80b
[Review] missing .
jmmartinez b1b0d71
[Review] operaiton -> operation
jmmartinez 437daf5
[Review] Do not set FPFastMathDefault to 0 by default / translate Con…
jmmartinez ebdcd76
[Review] make tests more reliable
jmmartinez 2c6901c
[Review] Emit the FastMathDefaultMode in a consistent order
jmmartinez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to remove this
FuncToFastMathFlagsstuff.It's used to set the
FPFastMathFlagsthat are attached to the execution mode to the individual instructions of a kernel.But since we're preserving the
FPFastMathFlagsin the metadata; I'm thinking that this is not needed anymore.@maarquitos14 should I remove this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this logic should be still placed somewhere as the middleend and backend are unlikely to know about this metadata out of the box and honestly it feels like for optimization passes it's easier to work with individual instruction flags. IMHO resolving
ExecutionModeto FP flag right away in the SPIR-V consumer won't harm and actually make implementation lower-level drivers friendly.@svenvh @vmaksimo WDYT?