[OpaquePointers] Add support for translating target extension types. #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target extension type for SPIR-V is essentially
target("spirv.TypeName", <image type>, <int params>).
Most of the work to support translation of these types has already happened
beforehand, so the primary step here is to enable translation work in
SPIRVWriter as well as making the SPIRVBuiltinHelpers work with target types as
well.
Constructing LLVM IR from SPIR-V using these types is not yet supported, mainly
out of uncertainty of the proper interface to let the resultant consumers
indicate that they wish to support these types.
Contributor
Author
|
The clang patch I wrote to generate these types is at https://reviews.llvm.org/D141008. |
svenvh
approved these changes
Jan 6, 2023
MrSidims
approved these changes
Jan 7, 2023
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
LGTM, but I suggest to wait for clang patch first to make sure that IR format is approved.
I also believe, that some of the .cl tests might require to be updated when clang patch is merged.
Contributor
|
https://reviews.llvm.org/D141008 is accepted by Anastasia, hence merging the patch |
MrSidims
pushed a commit
that referenced
this pull request
Mar 16, 2023
) The expected representation is: target("spirv.JointMatrixINTEL", %element_type, %rows%, %cols%, %scope%, %use%, (optional) %element_type_interpretation%) TODO: figure out, how to deal with the switch from old API (Matrix has Layout) to new API (Layout was removed) Depends on: #1799 intel/llvm#8343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target extension type for SPIR-V is essentially target("spirv.TypeName",![]()
, ).
Most of the work to support translation of these types has already happened beforehand, so the primary step here is to enable translation work in SPIRVWriter as well as making the SPIRVBuiltinHelpers work with target types as well.
Constructing LLVM IR from SPIR-V using these types is not yet supported, mainly out of uncertainty of the proper interface to let the resultant consumers indicate that they wish to support these types.