Fix out of bounds access in SPIRVToOCLBase::mutateArgsForImageOperands #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When called from visitCallSPIRVImageReadBuiltIn, Args only has three elements and ImOpArgIndex is 2. This has been causing this function to "update" an argument past the end of the vector, which caused a crash when running transcoding/image_signedness.ll on Windows because the debug build in Windows has bounds checking on std::vector. With this change, it should update the correct (and not past the end) argument instead and satisfy the Windows bounds checks.
bader
approved these changes
Jul 14, 2022
Member
|
Since the commit introducing the issue is also on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called from visitCallSPIRVImageReadBuiltIn, Args only has three
elements and ImOpArgIndex is 2. This has been causing this function to
"update" an argument past the end of the vector, which caused a crash
when running transcoding/image_signedness.ll on Windows because the
debug build in Windows has bounds checking on std::vector.
With this change, it should update the correct (and not past the end)
argument instead and satisfy the Windows bounds checks.