Fix for a bunch of fixed point integer SPIR-V instructions #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
|
Title comment: sincos_fixed() - is a SYCL math API. Here you bring a fix for a bunch of fixed point integer SPIR-V instructions, so the name should express it. |
MrSidims
reviewed
Sep 16, 2021
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
I believe, we should face the same issue for ArbitraryFloat instructions as well. I suggest to fix it simultaneously. Also some code from ArbitraryFloat can be adopted for fixed integer point instructions, but better to sync with @mlychkov about it.
MrSidims
reviewed
Sep 16, 2021
pauzinl
changed the title
MrSidims
reviewed
Sep 20, 2021
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Functionally and test-wise LGTM, thanks!
I just have some re-wording suggestion, I'll post next.
MrSidims
reviewed
Sep 20, 2021
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Suggesting in the code comment is also applicable to the PR comment.
mlychkov
reviewed
Sep 20, 2021
MrSidims
approved these changes
Sep 20, 2021
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
…oup#1213) If the return type of an instruction is wider than 64-bit, then this instruction will return via 'sret' argument added into the arguments list. Here we reverse this, removing 'sret' argument and restoring the original return type. TODO: currently 'sret' parameter attribute is being lost during reverse translation for the mentioned case, need to fix it.
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
… bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
…oup#1213) (KhronosGroup#15) If the return type of an instruction is wider than 64-bit, then this instruction will return via 'sret' argument added into the arguments list. Here we reverse this, removing 'sret' argument and restoring the original return type. TODO: currently 'sret' parameter attribute is being lost during reverse translation for the mentioned case, need to fix it.
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
…nstructions wi.. '"master"' -> '"xmain-web"' (26 commits) CONFLICT (content): Merge conflict in test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp commit 7904ea9 Author: Leonid Pauzin <[email protected]> Date: Thu Oct 14 19:53:45 2021 +0300 Store result of fixed point integer SPIR-V instructions wider than 64 bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
…er SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) (KhronosGroup#36) * Resolve of merge (conflict) 7904ea9 Store result of fixed point integer SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) CONFLICT (content): Merge conflict in test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp commit 7904ea9 Author: Leonid Pauzin <[email protected]> Date: Thu Oct 14 19:53:45 2021 +0300 Store result of fixed point integer SPIR-V instructions wider than 64 bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits * Resolve of merge (conflict) 7904ea9 Store result of fixed point integer SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) CONFLICT (content): Merge conflict in test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp commit 7904ea9 Author: Leonid Pauzin <[email protected]> Date: Thu Oct 14 19:53:45 2021 +0300 Store result of fixed point integer SPIR-V instructions wider than 64 bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits Co-authored-by: iclsrc <[email protected]>
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
…int integer SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) (KhronosGroup#36) * Resolve of merge (conflict) 7904ea9 Store result of fixed point integer SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) CONFLICT (content): Merge conflict in test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp commit 7904ea9 Author: Leonid Pauzin <[email protected]> Date: Thu Oct 14 19:53:45 2021 +0300 Store result of fixed point integer SPIR-V instructions wider than 64 bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits * Resolve of merge (conflict) 7904ea9 Store result of fixed point integer SPIR-V instructions wi.. '"master"' -> '"xmain-web"' (26 commits) CONFLICT (content): Merge conflict in test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp commit 7904ea9 Author: Leonid Pauzin <[email protected]> Date: Thu Oct 14 19:53:45 2021 +0300 Store result of fixed point integer SPIR-V instructions wider than 64 bits (KhronosGroup#1244) This if fix for KhronosGroup#1213 This patch adds Store instructions in cases when return value is wider than 64 bits Co-authored-by: iclsrc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be cases when return type of intrinsic is greater than 64 moves return value into argument list as sret parameter.
TODO: currently sret parameter attribute is being lost during reverse translation for the mentioned case, need to fix it.