Repository navigation
Name failed imports after the item, not its file - #1205
Merged
Merged
Conversation
When an import threw, the failed result was named after the file
(e.g. {guid}.config) and had no key or path. It now uses the node's
alias as the name and carries its key, path and site-relative file,
matching the success path.
Fixes #1200
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1200
When an item threw during import, its failed result was named after its file (
{guid}.config) and had no key or path, so it didn't line up with a successful import of the same item (seen in Publisher push results).Change
In the
catchinSyncHandlerRoot.ImportSingleElementAsync, the failure now uses:node.GetAlias()as the name (falling back to the file name if blank)GetNameFromFileOrNodeThe log message still uses the file name.
Note: the issue suggested
GetNameFromFileOrNodefor the name, but that returns the file path; the name the otherReportActioncalls use is the node alias.Tests
New
FailedImportNameTests: exports a page, deletes its doctype, re-imports and checks the failure's name, key and file. It fails without the fix (home.config, empty key). Full suite: 233 passed.v18 probably has the same code; check when forward-porting.
🤖 Generated with Claude Code