Repository navigation
Let callers choose where item previews come from - #1192
Merged
Merged
Conversation
The details dialog always previewed items from the site's uSync folders, so anything showing results for files elsewhere (a sync pack, a snapshot) got a preview of the wrong version. - ISyncPreviewService gets a GetPreviewAsync overload that takes the node, and an optional finder for the pending items it uses. - The details dialog data and usync-results take a previewSource: a function that loads the preview, or false for just the diff. Unset keeps the uSync folder preview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
This was referenced Nov 7, 2026
This was referenced Nov 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The details dialog always builds its preview from the site's uSync folders (
TryFindItemNodeAsync). Packages that show results for files somewhere else, such as a sync pack, a snapshot or a history event, open the same dialog throughusync-results. They got a preview of the uSync folder version of the item, not the one being reported.Changes
ISyncPreviewService.GetPreviewAsync(handlerAlias, XElement node, findNode?)builds the preview from the node it's given.findNode(handler, key)supplies the items the preview needs that aren't in Umbraco yet, so they come from the same place.previewSourceonuSyncDetailsModalDataandusync-results:falseshows just the diff.docs/item-previews.md) are updated.ISyncPreviewServicegains a member. It only shipped in 17.6.0, so it's unlikely anyone implements it yet.Testing
SyncPreviewServiceTestscheck that:🤖 Generated with Claude Code