vmm: don't vmap non-canonical addresses #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktt
force-pushed
the
check-non-canon
branch
2 times, most recently
from
7c7aaf7 to
68dc913
Compare
sktt
added
improvement
wipawel
reviewed
Nov 10, 2023
sktt
force-pushed
the
check-non-canon
branch
4 times, most recently
from
9c1e40b to
0f6d58c
Compare
minipli-oss
requested changes
Nov 13, 2023
Moving over the BITS_PER_LONG from bitmap.h to compiler.h. Shifting the sign bit to the highest position turns the pointer into a negative number that will remain sign extended when shifting it back down. Signed-off-by: Johannes Wikner <[email protected]>
sktt
force-pushed
the
check-non-canon
branch
from
0f6d58c to
798f4b6
Compare
minipli-oss
approved these changes
Nov 13, 2023
Contributor
minipli-oss
left a comment
minipli-oss
left a comment
There was a problem hiding this comment.
LGTM! Thanks, Johannes!
Contributor
Author
thanks for the great tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a non-canonical address to vmap would still map it, leading to #GP further down the line.
e.g.,
0xffff000000000000would map address for va=0. Let's just return NULL.