Make local APIC timer really local; improve timers initialization; interrupts restore #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
improvement
sktt
requested changes
Nov 8, 2023
Contributor
sktt
left a comment
sktt
left a comment
There was a problem hiding this comment.
Nice!
My only question is if READ_ONCE is required for these fields that are declared volatile for ticks and apic_ticks already?
minipli-oss
reviewed
Nov 10, 2023
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
APIC timer is not a replacement for PIT. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
The ticks variable is declared as volatile, and updated only on BSP. But might be accessed by other CPUs and hence more atomic update. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Detect and record global timers (HPET or PIT) enablement in boot_flags. Detect and record APIC timer enablement in PERCPU variable. Check if corresponding timers are on and return -ENODEV otherwise in msleep() functions. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
wipawel
force-pushed
the
apic_timer_fix
branch
from
ab50867 to
5ea83c8
Compare
wipawel
changed the title
minipli-oss
approved these changes
Nov 13, 2023
sktt
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.