Improve dump_pagetables() functionality #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
improvement
sktt
requested changes
Nov 5, 2023
Contributor
sktt
left a comment
sktt
left a comment
There was a problem hiding this comment.
looks good from here, just pointing out the FIXME's that can now use the merged warning macro
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Make the dump_pagetables() self-sufficient by having it map the page tables it traverses automatically. Refactor and simplify code by extracting common functionality into separate inline functions. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
These functionality dumps the current state of page tables for specified CR3 only for a given virtual address. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
wipawel
force-pushed
the
dump_pagetables
branch
from
a418658 to
77b04f0
Compare
sktt
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.