Implement API to find the frame for a given virtual address #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
feature
sktt
requested changes
Nov 7, 2023
sktt
reviewed
Nov 8, 2023
Contributor
sktt
left a comment
sktt
left a comment
There was a problem hiding this comment.
I resolved a few comments. One question mainly remains
sktt
previously approved these changes
Nov 8, 2023
wipawel
force-pushed
the
get_frame
branch
2 times, most recently
from
256a324 to
00e126f
Compare
minipli-oss
requested changes
Nov 16, 2023
Contributor
minipli-oss
left a comment
minipli-oss
left a comment
There was a problem hiding this comment.
Looks good, only minor changes needed.
The functions traverse specified page tables and obtain a MFN and frame order for a specified virtual address. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #202.