Add warning functionality (warning(), WARN() and WARN_ON()) #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many places in the KTF setup code we used panic() as a coping mechanism for unexpected situations. However, not all of these situations were fatal. Instead of halting execution completely, use an easy to spot warning message and continue execution. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Some BUG_ONs are more of a development help rather then potential bugs. Use more appropriate ASSERT for them instead. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
wipawel
added
the
improvement
sktt
approved these changes
Nov 4, 2023
Contributor
sktt
left a comment
sktt
left a comment
There was a problem hiding this comment.
Nice streak of PRS :) thanks
Lgtm
Will check the rest later or tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes KTF report certain unexpected situations in a noticeable form instead of panicking.