Add reboot functionality #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
the
improvement
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
This function triggers Triple Fault by loading NULL IDT pointer and issuing an int3 instruction. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
sktt
previously approved these changes
Sep 8, 2023
Contributor
sktt
left a comment
sktt
left a comment
There was a problem hiding this comment.
nice! Looks good from here :)
minipli-oss
requested changes
Sep 8, 2023
The reboot() uses either acpi_reboot() (when ACPICA support is compiled in) or keyboard_reboot (when i8042 controller is present). It fallbacks to the hard_reboot() as a last resort. The reboot() is called only upon i8042's handled CTRL+ALT+DEL key combination. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
The UART reboot functionality looks for '+++' character string input received via UART and calls reboot() when detected. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
In case communication with KTF is not possible (no PS/2 keyboard nor UART port) add an option to automatically reboot after specified amount of time. The reboot_timeout by default is off. Value 0 means reboot immediately. Values unit is seconds. Please note a timer needs to be enabled for this functionality to work. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support reboot via three means:
Support reboot triggering via three ways:
+++character sequencereboot_timeout=which automatically reboots after a specified number of seconds (requires a timer)