Fix interrupts handling and improve syscall/exception stack handling #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Add generic _from_usermode and _to_usermode macros that switch pagetable, swap GS and optionally switch stack. Use these macros in syscall_(from/to)_usermode macros directly. Rename enter_(from/to)_usermode macros to cond_(from/to)_usermode macros to highlight the conditional nature of transition. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
There is no need to switch stack for sysenter and int80 as the CPU switches to TSS.RSP0. However, it is still necessary for SYSCALL_EXIT since we are terminating the user task. Also, there is no need to save user registers for SYSCALL_EXIT. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
wipawel
added
bugfix
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
By treating both error_code and vector as machines words (either 32bit or 64bit based on built architecture) we simplify handling of the exceptions across architectures. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
On IRQ entry always push fake error_code value (always zero) and a corresponding IRQ vector number on the stack to make its layout match the exception stack frame layout. This simplifies the handling of both exceptions and interrupts. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
The proper order of initialization is: ACPI -> IOAPIC -> Timers. The ACPI provided MADT table provides configuration for IOAPICs and for example HPET. Also, initialized IOAPIC is required by timers to setup their IRQs. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
requested changes
Sep 1, 2023
Contributor
minipli-oss
left a comment
minipli-oss
left a comment
There was a problem hiding this comment.
Looking good, just a few more nits.
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
approved these changes
Sep 1, 2023
Contributor
minipli-oss
left a comment
minipli-oss
left a comment
There was a problem hiding this comment.
Thanks a lot, Pawel!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.