pagetables: allow user and kernel maps in same pgd #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
reviewed
Aug 30, 2023
Contributor
wipawel
left a comment
wipawel
left a comment
There was a problem hiding this comment.
Thanks for the PR. Somehow this change makes me uneasy. But I do see the value for testing.
sktt
force-pushed
the
high_user_addresses
branch
from
6b42dfc to
3418264
Compare
wipawel
reviewed
Aug 31, 2023
Contributor
wipawel
left a comment
wipawel
left a comment
There was a problem hiding this comment.
Other than the comment LGTM
sktt
force-pushed
the
high_user_addresses
branch
2 times, most recently
from
b72d7a5 to
31eafdd
Compare
KTF allows user mode to allocate high addresses, which normally are only available to kernel. However, to handle this somewhat gracefully, we need to check if already-existent page table protection bits conflicts with those of a new pgentry. This means that we may fixup NX, RW or USER flags if the new mapping is more permissive than current one. This is a bit sketchy, yet useful for certains tests. Therefore, print a big warning if this ever happens. Signed-off-by: Johannes Wikner <[email protected]>
sktt
force-pushed
the
high_user_addresses
branch
from
31eafdd to
7ca8552
Compare
wipawel
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KTF allows user mode to allocate high addresses, which normally are only available to kernel. However, to handle this somewhat gracefully, we need to check if already-existent page table protection bits conflicts with those of new maps.
We downgrade the current flags if the most recent mapping's flags are more permissive than current flags. This is all a bit sketchy but useful, so print a big warning if this ever happens.