pagetable enhancements #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking cr3 as argument allows dumping page tables of user mode. Signed-off-by: Johannes Wikner <[email protected]>
I think using X for executable makes more sense than using it for Non-Executable. Signed-off-by: Johannes Wikner <[email protected]>
wipawel
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to debug an issue with user mode mappings, which resulted in the following patches.
It's useful to see what mappings usermode has. To do this, dump_pagetables takes a cr3_t type argument, which can be for example be user_cr3.
I think executable should show
Xinstead of the vice-versa.. But that's just an opinion, so we can drop this.