pmm: properly detect first available memory region #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the first available usable region we need a space of at least EARLY_VIRT_MEM MB, which is not below first MB. Since some UEFI firmware allocates more than one usable region below the first MB with size of 4096 bytes, it is better to dynamically scan all usable regions and select the first one matching above criteria. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
|
Thanks!! Tested on a Thinkstation P360 Tower (1S)MT that had the affected issue and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first available usable region we need a space of at least EARLY_VIRT_MEM MB, which is not below first MB.
Since some UEFI firmware allocates more than one usable region below the first MB with size of 4096 bytes, it is better to dynamically scan all usable regions and select the first one matching above criteria.