Bug/syscall return #276
Bug/syscall return #276
Conversation
The previous method would get optimized out by compiler. Using asm volatile instead. Signed-off-by: Johannes Wikner <[email protected]>
| * GRUB2 bootloader tools - `grub2-common` package (e.g. `apt install grub2-common`) | ||
| * ISO generation tools - `xorriso` package (e.g. `apt install xorriso`) | ||
| * ISO generation tools - `xorriso` and `mtools` package (e.g. `apt install xorriso mtools`) | ||
|
|
There was a problem hiding this comment.
mtools is needed for creating the ISO via grub-mkrescue? If so, you should mention that in the commit log, at least. However, it should already had been installed via the grub2-common package, as that depends on grub-common which "suggests" mtools. But yeah, it's not a strong dependency, so we may want to make it explicit.
| ); | ||
| /* clang-format on */ | ||
| return return_code; | ||
| } |
There was a problem hiding this comment.
WTF is this?! Why isn't this a simple return return_code?.... Oh, I see. syscall_handler(), what a bummer! It does the right thing only by chance. We'd better rewrite that think with a ASM thunk instead of this fragile register pinning code (gcc is free to reuse these registers, you know ;)).
There was a problem hiding this comment.
You are right of course, the current implementation of syscall handling is indeed quite fragile. I plan to improve it all at some point.
|
Oh, heh, I took too long to read and comment, Pawel already merged it :D |
3 participants
No description provided.