cpuid: move functions from cpuid.h into cpuid.c #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82marbag
reviewed
Jan 24, 2022
82marbag
previously approved these changes
Jan 24, 2022
dkgupta-amzn
previously approved these changes
Jan 24, 2022
Contributor
dkgupta-amzn
left a comment
dkgupta-amzn
left a comment
There was a problem hiding this comment.
I've only one comment on when "get_cpu_freq" returns 0, how should we treat that at callsite?
Otherwise PR is approved.
auto-merge was automatically disabled
January 24, 2022 21:02
Rebase failed
While at it, move cpuid.h into arch/x86 directory. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
82marbag
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in cpuid.h deserve their own C file and should not be inlined. The CPUID functionality should also go to arch/x86 directories.