Cleanups #221
Merged
Cleanups #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1] the __naked attribute is only meant for functions with basic asm bodies. But neither kernel_main() nor ap_startup() is, so drop the bogus attribute. It's, at best, a micro optimization not worth the trouble. However, make kernel_main() a __noreturn function as that's what it is. [1] https://gcc.gnu.org/onlinedocs/gcc/x86-Function-Attributes.html#index-naked-function-attribute_002c-x86 Signed-off-by: Mathias Krause <[email protected]>
Various minor cleanups: - use 16bit source registers when assigning segment registers to have matching register sizes - don't obfuscate CR0 initialization, make it plain obvious we're enabling protected mode - do the same for CR4 initalization, make it obvious we're setting it to PSE|PAE - drop the unneded CLD, as we've fully assigned RFLAGS already with the POPF Signed-off-by: Mathias Krause <[email protected]>
Contributor
Author
|
Had a braino in the top commit, so dropped it. |
Contributor
|
LGTM. Thanks! |
wipawel
approved these changes
Oct 15, 2021
82marbag
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanups I ran into while working on the extables fixes.
Boilerplate disclamer follows:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.