Skip to content

setup: use tail-call for kernel_main jump #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
82marbag merged 1 commit into from
Oct 8, 2021
Merged

setup: use tail-call for kernel_main jump #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/setup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ void __noreturn __text_init kernel_start(uint32_t multiboot_magic,
init_keyboard(get_bsp_cpu_id());

/* Jump from .text.init section to .text */
asm volatile("push %0; ret" ::"r"(&kernel_main));
asm volatile("jmp kernel_main");
Copy link
Contributor

@minipli-oss minipli-oss Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply drop the inline ASM and call kernel_main() as it's supposed to be?:

    kernel_main();


UNREACHABLE();
}