This repository was archived by the owner on Nov 27, 2023. It is now read-only.
fix(Visualization): Initial node isn't always centered #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 43.00% 42.75% -0.26%
==========================================
Files 48 48
Lines 1465 1483 +18
Branches 315 323 +8
==========================================
+ Hits 630 634 +4
- Misses 793 805 +12
- Partials 42 44 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@javierlopezdeancos can you check both warnings from sonarcloud? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I think we need @kahboom or @mmelko to take a look at this, this is beyond what I fear to touch the frontend at this point :) Thank you @javierlopezdeancos ! |
|
Don't worry @Delawen, I'll wait for your suggestions! |
kahboom
approved these changes
Jan 4, 2023
|
thank you @javierlopezdeancos for your contribution, this looks good to me :) |
|
A pleasure to contribute, I will try to do it regularly |
kahboom
pushed a commit
that referenced
this pull request
Jan 4, 2023
* fix: (Visualization): center initial node * fix: (Visualization): fix remove condition is redundant with previously checked one * fix: (Visualization): remove duplicated import path * fix: set ref with an element type defined Co-authored-by: Javier Lopez de Ancos <[email protected]>
kahboom
pushed a commit
to kahboom/kaoto-ui
that referenced
this pull request
Jan 17, 2023
…#1010) * fix: (Visualization): center initial node * fix: (Visualization): fix remove condition is redundant with previously checked one * fix: (Visualization): remove duplicated import path * fix: set ref with an element type defined Co-authored-by: Javier Lopez de Ancos <[email protected]>
kahboom
pushed a commit
to kahboom/kaoto-ui
that referenced
this pull request
Jan 17, 2023
…#1010) * fix: (Visualization): center initial node * fix: (Visualization): fix remove condition is redundant with previously checked one * fix: (Visualization): remove duplicated import path * fix: set ref with an element type defined Co-authored-by: Javier Lopez de Ancos <[email protected]>
mmelko
added a commit
to mmelko/kaoto-ui
that referenced
this pull request
Jan 20, 2023
…-archive#1010)" This reverts commit a408a13.
kahboom
pushed a commit
that referenced
this pull request
Jan 20, 2023
mmelko
pushed a commit
to mmelko/kaoto-ui
that referenced
this pull request
Jan 23, 2023
…#1010) * fix: (Visualization): center initial node * fix: (Visualization): fix remove condition is redundant with previously checked one * fix: (Visualization): remove duplicated import path * fix: set ref with an element type defined Co-authored-by: Javier Lopez de Ancos <[email protected]>
mmelko
added a commit
to mmelko/kaoto-ui
that referenced
this pull request
Jan 23, 2023
…chive#1139) * Revert "fix(Visualization): Initial node isn't always centered (kaoto-archive#1010)" This reverts commit a408a13. * fix(Visualisation): tweak centering of the initial node fix kaoto-archive#1096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix and Close: #952
Summary of changes
useEffectto detect if nodes only have the initial "ADD A STEP" node to set their position in the React Flow viewportIf user switch between horizontal/vertical flow, the position should be re calculated in the
useEffectScreenshots