Skip to content

Create inflate-netkan command#355

Merged
HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:feature/inflate-command
Jun 27, 2025
Merged

Create inflate-netkan command#355
HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:feature/inflate-command

Conversation

@HebaruSan
Copy link
Copy Markdown
Member

@HebaruSan HebaruSan commented Jun 27, 2025

Motivation

https://github.com/HebaruSan/inflate-netkan is a GitHub Action that is set up in the NetKAN and KSP2-NetKAN repos to allow org members to add a requested mod to the inflation queue:

It works, but its implementation is not optimal:

  • It's a core (if tertiary) part of the infrastructure that lives in my account rather than the main KSP-CKAN org, so it can't be maintained by anyone else without my participation
  • It has a Dockerfile, which means there's a build step before it can be executed
  • It internally hard-codes the names of the inflation queues for each game
  • It imports Python code from NetKAN-Infra to create its own standalone mini command, which must violate some sort of layered design principle
  • It was cobbled together based on snippets from the Scheduler, so even though there isn't much Python code, a lot of it is managing arrays that will only ever have one element

Changes

Now a simple new inflate-netkan command is created to add the netkan with the given identifier to the given inflation queue. This will allow the workflows in NetKAN and KSP2-NetKAN to use the already built kspckan/netkan container instead of building a new container on the fly (similar to KSP-CKAN/CKAN#4265).

@HebaruSan HebaruSan added Enhancement New feature or request Inflator Receives netkans and generates ckans labels Jun 27, 2025
@HebaruSan HebaruSan merged commit fadbe27 into KSP-CKAN:master Jun 27, 2025
3 checks passed
@HebaruSan HebaruSan deleted the feature/inflate-command branch June 27, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Inflator Receives netkans and generates ckans

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant