Skip to content

Conversation

@hyrodium
Copy link
Contributor

tuple_type_head, tuple_type_tail, tuple_type_cons, setindex are imported, but unused in the code.

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (e3773b6) to head (f961d58).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   86.99%   89.14%   +2.15%     
==========================================
  Files           1        1              
  Lines         123      129       +6     
==========================================
+ Hits          107      115       +8     
+ Misses         16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho Jutho merged commit 39b2b0a into Jutho:master Feb 23, 2024
@Jutho
Copy link
Owner

Jutho commented Feb 23, 2024

Thanks.

@Jutho
Copy link
Owner

Jutho commented Jul 29, 2024

We are getting some errors in our packages building on TupleTools because of this, so I will probably revert it. The idea behind importing these names was that you could write TupleTools.functionname for a number of useful functions for manipulating tuples, irrespective of whether the implementation was provided by Base, or a more efficient implementation was provided in TupleTools. So TupleTools.setindex should just work, even if this is actually just Base.setindex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants