Small updates #19
Merged
Small updates #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also closes #18 |
Jutho
reviewed
Feb 9, 2024
| """ | ||
| function indexin(a::Tuple, b::Tuple) | ||
| return ntuple(i -> findfirst(==(a[i]), b), length(a)) | ||
| end |
Owner
There was a problem hiding this comment.
I guess this one is not type stable, because findfirst can return nothing?
One possibility would be to explicitly error when elements are missing, but then it differs from the Base method and we should maybe name it differently.
Collaborator
Author
There was a problem hiding this comment.
Indeed, the Base method always returns a Vector{Union{Nothing,Int}}, and is therefore type stable. I checked the inferred type of this function, and it's still NTuple{N, Union{Nothing,Int}}, which might be fine as supposedly small type unions are ok.
Owner
There was a problem hiding this comment.
Sure. I just hope it doesn't lead to type instabilities further down in methods that use this, but I guess not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some functions that were previously missing, such as
circshiftandindexin.As a small note, for the implementation of$\mathcal{O}(N)$ , but as this package focusses on small tuples, I choose to use a simple $\mathcal{O}(N^2)$ algorithm, which is non-allocating. (I think)
indexin, for large tuples an implementation via a hash map would be more efficientAlso, it updates the codecov action, and Aqua tests to reflect the latest versions.
It also adds compat entries for the test dependencies.