Skip to content

Conversation

@simeonschaub
Copy link
Contributor

Should be completely harmless for all Julia versions. myid was actually from Distributed and in 1.6 Test doesn't reexport that anymore, so this now also adds an explicit dependency on Distributed.

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   75.45%   75.45%           
=======================================
  Files           3        3           
  Lines         220      220           
=======================================
  Hits          166      166           
  Misses         54       54           
Impacted Files Coverage Δ
src/timedtest.jl 65.03% <ø> (ø)
src/constinferred.jl 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf7cb1...d309b4c. Read the comment docs.

@Jutho
Copy link
Owner

Jutho commented Oct 12, 2020

It seems we should rather switch to the new behaviour implemented in JuliaLang/julia#37809 for the issue regarding myid. I will have to study this though. This part of the code is very much copy paste, so I don't know all the details of it. Could be a separate PR though. But I would prefer to restrict dependencies (even if it is to stdlib) as much as possible.

@Jutho
Copy link
Owner

Jutho commented Oct 12, 2020

I forgot to mention: thanks for fixing the original esc issue

@simeonschaub
Copy link
Contributor Author

Yes, I didn't look into the issue with myid to deeply, so feel free to push to this branch, if you have a better solution in mind.

@Jutho Jutho merged commit 8ef0ee7 into Jutho:master Oct 12, 2020
@simeonschaub simeonschaub deleted the prepare_for_37573 branch October 12, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants