Conversation
Add JupiterOneStorageEngine config type Write dotenv file for jupiterone storage engine Refactor config.storage to StarbaseStorage<any>[] Support multiple storage backends, if configured Update Changelog Implements #60
|
NOTE: this PR does not address instanceId validation or support integration API tokens. Additionally, it introduces very minor buggy behavior when running starbase locally several times--the These sharp edges will be filed off in future PRs. |
|
Thanks for the PR! Looks great! I had one comment on the handling of the I'd recommend we tag this as a major revision change due to it being a breaking change for anyone using the current storage configuration yaml format that doesn't list them in an array. |
|
So... technically, a major version bump here would put us at 1.0.0, which I don't think communicates what we want here. Pre-1.0, all non-patch changes should be considered breaking anyway, so I vote for a minor bump. |
35d42e2 to
80a9984
Compare
|
🚀 PR was released in |
Add JupiterOneStorageEngine config type
Write dotenv file for jupiterone storage engine
Refactor config.storage to StarbaseStorage[]
Support multiple storage backends, if configured
Update Changelog
Implements #60