Skip to content

Add 'jupiterone' storage engine#79

Merged
erichs merged 2 commits intomainfrom
60-support-j1-storage-engine
Oct 20, 2022
Merged

Add 'jupiterone' storage engine#79
erichs merged 2 commits intomainfrom
60-support-j1-storage-engine

Conversation

@erichs
Copy link
Contributor

@erichs erichs commented Oct 19, 2022

Add JupiterOneStorageEngine config type
Write dotenv file for jupiterone storage engine
Refactor config.storage to StarbaseStorage[]
Support multiple storage backends, if configured
Update Changelog

Implements #60

Add JupiterOneStorageEngine config type
Write dotenv file for jupiterone storage engine
Refactor config.storage to StarbaseStorage<any>[]
Support multiple storage backends, if configured
Update Changelog

Implements #60
@erichs erichs requested a review from a team as a code owner October 19, 2022 02:21
@erichs erichs requested a review from a team October 19, 2022 02:21
@erichs
Copy link
Contributor Author

erichs commented Oct 19, 2022

NOTE: this PR does not address instanceId validation or support integration API tokens. Additionally, it introduces very minor buggy behavior when running starbase locally several times--the .env file will accumulate values.

These sharp edges will be filed off in future PRs.

@adam-in-ict
Copy link
Contributor

Thanks for the PR! Looks great! I had one comment on the handling of the apiBaseUrl configuration value, but other than that, I think it's ready for approval.

I'd recommend we tag this as a major revision change due to it being a breaking change for anyone using the current storage configuration yaml format that doesn't list them in an array.

@erichs
Copy link
Contributor Author

erichs commented Oct 20, 2022

So... technically, a major version bump here would put us at 1.0.0, which I don't think communicates what we want here. Pre-1.0, all non-patch changes should be considered breaking anyway, so I vote for a minor bump.

@erichs erichs requested a review from adam-in-ict October 20, 2022 18:22
@adam-in-ict adam-in-ict added minor Increment the minor version when merged release Create a release when this pr is merged labels Oct 20, 2022
@erichs erichs force-pushed the 60-support-j1-storage-engine branch from 35d42e2 to 80a9984 Compare October 20, 2022 19:01
@erichs erichs requested a review from adam-in-ict October 20, 2022 19:02
@erichs erichs merged commit 786d50e into main Oct 20, 2022
@erichs erichs deleted the 60-support-j1-storage-engine branch October 20, 2022 19:08
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v0.5.0 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants