Skip to content

Disable Schema Validation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zemberdotnet merged 1 commit into from
Jun 7, 2022
Merged

Disable Schema Validation #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/starbase/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ import { StarbaseConfig, StarbaseIntegration } from './types';
import { executeWithLogging } from './process';

async function collectIntegrationData(integrationDirectory: string) {
await executeWithLogging(`yarn --cwd ${integrationDirectory} start;`);
await executeWithLogging(
`yarn --cwd ${integrationDirectory} start --disable-schema-validation;`,
Copy link
Copy Markdown
Contributor

@VDubber VDubber Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should allow arbitrary args to be passed down to this command.

Copy link
Copy Markdown
Member Author

@zemberdotnet zemberdotnet Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should allow that. I think, but am not completely sure, that invalid flags are ignored by the SDK.

Copy link
Copy Markdown
Contributor

@adam-in-ict adam-in-ict Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the SDK will complain about an invalid option if you provide a flag it's not expecting. I think either option is great and really appreciate the addition!

An argument in favor of allowing arbitrary args is it would also allow Starbase users to specify only a subset of steps to execute with the --step option. And certainly other benefits as well, but that's the one that immediately comes to mind as potentially useful.

);
}

async function writeIntegrationDataToNeo4j(
Expand Down