Add normalizeGraphObjectKey to createMockExecutionContext#1123
Open
Gonzalo-Avalos-Ribas wants to merge 2 commits intomainfrom
Open
Add normalizeGraphObjectKey to createMockExecutionContext#1123Gonzalo-Avalos-Ribas wants to merge 2 commits intomainfrom
Gonzalo-Avalos-Ribas wants to merge 2 commits intomainfrom
Conversation
| entities: preContext.jobState.collectedEntities, | ||
| relationships: preContext.jobState.collectedRelationships, | ||
| setData: preContext.jobState.collectedData, | ||
| normalizeGraphObjectKey: invocationConfig.normalizeGraphObjectKey, |
Contributor
Author
There was a problem hiding this comment.
This is the only change, only affects executeStepsWithDependencies
mscottford
force-pushed
the
NO-TICKET-add-normalize-graph-object-key-to-mock-execution-context
branch
from
c131d50 to
efda5d6
Compare
mscottford
force-pushed
the
NO-TICKET-add-normalize-graph-object-key-to-mock-execution-context
branch
from
efda5d6 to
7868d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding normalizeGraphObjectKey to createMockExecutionContext. This previously made
executeStepWithDependenciesto not call thenormalizeGraphObjectKeydeclared in the invocationConfig. That made some integrations behave differently when running tests than when actual collection running.