[sonic-snmpagent] SONiC physical entity mib extension#1
Closed
Junchao-Mellanox wants to merge 15 commits intomasterfrom
Closed
[sonic-snmpagent] SONiC physical entity mib extension#1Junchao-Mellanox wants to merge 15 commits intomasterfrom
Junchao-Mellanox wants to merge 15 commits intomasterfrom
Conversation
keboliu
reviewed
Sep 4, 2020
| "tx4power": 43, | ||
| } | ||
|
|
||
| PSU_SENSOR_PART_ID_MAP = { |
Owner
Author
There was a problem hiding this comment.
Yes, all sensor values can get from platform API. If vendor doesn't implement the API, we will give it a None value in psud and it won't be displayed in mib.
Add 'wheel' to the list of packages required for building the package. This way it will be implicitly installed at build time, preventing the need to intstall the 'wheel' package explicitly in our build environment.
* [BGP]: Currently the data required for CiscoBgp4MIB is retrieved from bgpd deamon. snmp_ax_impl connects to bgpd daemon via tcp socket and retreives the BGP neighbor information required for CiscoBgp4MIB. This design is modified to support multi-asic platform. The data required by CiscoBgp4MIB can be populated in STATE_DB by a new daemon in BGP docker. Changes made: - snmp_ax_impl to retrieve NEIGH_STATE_TABLE from STATE_DB. This change will affect both single and multi asic platforms. - Update bgp MIB unit tests to use STATE_DB data instead of using vtysh socket.
…sonic-net#161) reinit_data. udpate_data and reinit_data will be invoked by periodic events. update_data need not be invoked by reinit_data again. Additional invocation of update_data can cause increase in running time on multi-asic platform causing Agentx socket connection to break. Signed-off-by: SuvarnaMeenakshi <[email protected]>
…ss without IPv4 address (sonic-net#164) * Fix mgmt_ip_sub_oid default value to prevent later exception * Refix * Reimplement LLDPLocManAddrUpdater * Fix test case * Revert some back and fix lookup()
[LLDP]: Update init_db to load global database config before initializing SonicV2Connector class. LLDPLocManAddrUpdater requires information from host database hence uses init_db() to initialize the host db. For unit-testing multi-asic code path, there are mock db files provided for global_db and namespace specific dbs. As init_db did not load global database config, unit-test mock db was not loading global_db database files for LLDPLocManAddrUpdater unit-testing. Fixed this by loading global database config in init_db function. Fixed by: Loading global database config in init_db() unit-test: Loading mock db files from "global_db" director for multi-asic platform if namespace is empty or None.
…Pv6 address (sonic-net#167) * Add a test case for LLDP_LOC_CHASSIS.lldp_loc_man_addr has only one IPv6 address * Remove IPv4 on asicN namespace's appl_db
keboliu
approved these changes
Oct 16, 2020
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add new physical entity fan drawer, fan, fan tachometers, PSU, PSU sensor, chassis sensors to physical entity mib.
Implement all mib objects defined in EntPhysicalEntry of RFC 2737.
- How I did it
Refactor rfc2737.py to have different mib updater for different physical entity: XcvrCacheUpdater, FanCacheUpdater, FanDrawerCacheUpdater, PsuCacheUpdater, ThermalCacheUpdater.
- How to verify it
Manual test on MSN2410
- Description for the changelog