Fix issue: should always check return value of a function if the function may return None#20
Closed
Junchao-Mellanox wants to merge 2 commits intomasterfrom
Closed
Fix issue: should always check return value of a function if the function may return None#20Junchao-Mellanox wants to merge 2 commits intomasterfrom
Junchao-Mellanox wants to merge 2 commits intomasterfrom
Conversation
…tion may return None
keboliu
approved these changes
Feb 24, 2023
Owner
Author
|
CI passed |
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 20, 2025
… 202412 (#20) ```<br>* a185761 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-02-14) [Sonic Automation] * c735073 - (origin/202411) [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
Motivation and Context
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
How Has This Been Tested?
Created unit test cases to avoid such thing happening
Additional Information (Optional)