[Mellanox] Adjust test cases for fan led support#8
Closed
Junchao-Mellanox wants to merge 4 commits intomasterfrom
Closed
[Mellanox] Adjust test cases for fan led support#8Junchao-Mellanox wants to merge 4 commits intomasterfrom
Junchao-Mellanox wants to merge 4 commits intomasterfrom
Conversation
| return 'red' | ||
|
|
||
| for fan_data in self.fan_data_list: | ||
| if fan_data.get_expect_led_color(): |
Owner
Author
There was a problem hiding this comment.
fan_data.get_expect_led_color() == 'red'
liat-grozovik
approved these changes
Apr 13, 2020
keboliu
approved these changes
Apr 17, 2020
Owner
Author
|
Community PR sonic-net#1580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add test case for fan led management enhancement.
Type of change
Approach
How did you do it?
How did you verify/test it?
Manually run the test cases
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
All existing topologies
Documentation