Fix tests for new version of ConcurrentUtilities
#1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ConcurrentUtilities` changed an (internal) fieldname of the `Pool` type from `max` to `limit`. This field is used in HTTP.jl tests so this patch works around the issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
=======================================
Coverage 82.70% 82.70%
=======================================
Files 32 32
Lines 3053 3053
=======================================
Hits 2525 2525
Misses 528 528 ☔ View full report in Codecov by Sentry. |
This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref JuliaWeb#920 (comment)).
nickrobinson251
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Fix tests for new version of `ConcurrentUtilities` `ConcurrentUtilities` changed an (internal) fieldname of the `Pool` type from `max` to `limit`. This field is used in HTTP.jl tests so this patch works around the issue. * Remove invalidation CI check This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref #920 (comment)).
nickrobinson251
pushed a commit
that referenced
this pull request
Feb 18, 2024
* Fix tests for new version of `ConcurrentUtilities` `ConcurrentUtilities` changed an (internal) fieldname of the `Pool` type from `max` to `limit`. This field is used in HTTP.jl tests so this patch works around the issue. * Remove invalidation CI check This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref #920 (comment)).
nickrobinson251
added a commit
that referenced
this pull request
Feb 18, 2024
* Fix tests for new version of `ConcurrentUtilities` `ConcurrentUtilities` changed an (internal) fieldname of the `Pool` type from `max` to `limit`. This field is used in HTTP.jl tests so this patch works around the issue. * Remove invalidation CI check This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref #920 (comment)). Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConcurrentUtilitieschanged an (internal) fieldname of thePooltype frommaxtolimit. This field is used in HTTP.jl tests so this patch works around the issue.